Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden)

[pkx166h]

On 2015/06/07 20:43:54, Keith wrote:
> lgtm, if you can narrow the convert-ly rule a bit and test it (the
> semi-automated 'patchy' testing doesn't use convert-ly)

> Also, I think you need to add

Documentation/snippets/new/blanking-staff-lines-using-the--whiteout-command.ly
> and let the makelsr script update the copy in /snippets/, but I'm
always
> confused about that so just check the Contibutors' Guide

Yes, do not edit the snippet directly in ../snippets/.. or add it
directly to the snippets/.. directory.

Put any new snippet in snippets/new/.. and edit any existing snippet
also in the snippets/new/.

The makelsr.py script (located in scripts/auxiliar/) is then run and it
will scan the snippets/new dir and do what it needs to do (update
existing snippets or add new ones to the 'snippets' directory as well as
adding them to the relevant texi files for the snippets.pdf/html files).

If you are testing the patch yourself (even if you are not doing a full
make doc) you will need to run the makelsr script before testing,
however it is usually best practice to NOT apply the patch for review
with the makelsr run, but generally run the makelsr after the patch has
been pushed and push that separately. It makes it easier to revert or
keep track of changes - some makelsr changes can produce a lot of tiny
changes.

James



https://codereview.appspot.com/236480043/