[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: add stencil-whiteout-outline function (issue 236480043 by address@hi
From: |
k-ohara5a5a |
Subject: |
Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden) |
Date: |
Sun, 07 Jun 2015 20:43:54 +0000 |
lgtm, if you can narrow the convert-ly rule a bit and test it (the
semi-automated 'patchy' testing doesn't use convert-ly)
Also, I think you need to add
Documentation/snippets/new/blanking-staff-lines-using-the--whiteout-command.ly
and let the makelsr script update the copy in /snippets/, but I'm always
confused about that so just check the Contibutors' Guide
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely#newcode66
Documentation/changes.tely:66: now create a white background that
follows the outline of the
Better to be honest
"that follows the outline of"
-> "built from multiple displaced copies of"
https://codereview.appspot.com/236480043/diff/60001/Documentation/changes.tely#newcode69
Documentation/changes.tely:69: @code{\whiteout-box} markup command.
Setting the @code{whiteout}
Later, everything from "Setting the ..." on could be replaced by a
one-measure @lilypond[quote] example.
https://codereview.appspot.com/236480043/diff/60001/python/convertrules.py
File python/convertrules.py (right):
https://codereview.appspot.com/236480043/diff/60001/python/convertrules.py#newcode3766
python/convertrules.py:3766: str = re.sub (r"\\whiteout(?!-box)",
r"\\whiteout-box", str)
Somebody has probably defined \whiteout-custom or similar so you should
match more narrowly \\whiteout(?![a-z_-])
https://codereview.appspot.com/236480043/
Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden), paulwmorris, 2015/06/08
Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden), paulwmorris, 2015/06/10
Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden), pkx166h, 2015/06/14
Re: add stencil-whiteout-outline function (issue 236480043 by address@hidden), pkx166h, 2015/06/17