Re: [Ltib] [PATCH] Dillo2 Web Browser

[Alan Carvalho de Assis]

Hi Stuart,

On 7/15/09, Stuart Hughes <address@hidden> wrote:
> Hi Alan,
>
> Thanks for re-factoring this, it made it much easier to look at in
> complete context.  It mostly looks okay, but I have a few comments and
> questions:
>
> ---+ dillo2.diff:
>
>     * packages.lkc: I'd like to keep the indent for
>       select clauses like others (formatting consistency)
>

Ok, fixed

>     * fltk2.spec: I'd like Source: reference the 'rev' tag
>       defined
>

It is not accepting to use the 'rev' tag:

Source          : %{name}-%{version}-{rev}.tar.bz2

Processing: fltk2
===================
dropping %{rev} in spec token: sources
dropping %{rev} in spec token: pkg_dir_name
Build path taken because: no prebuilt rpm,
Try fltk-2.0.x-.tar.bz2.md5 from the GPP
http://bitshrine.org/gpp/fltk-2.0.x-.tar.bz2.md5:
10:40:27 ERROR 404: Not Found.
Try fltk-2.0.x-.tar.bz2 from the GPP
http://bitshrine.org/gpp/fltk-2.0.x-.tar.bz2:
10:40:28 ERROR 404: Not Found.
Can't get: fltk-2.0.x-.tar.bz2 at ./ltib line 788.


I solved it this way:

Release         : r6793
Source          : %{name}-%{version}-%{release}.tar.bz2

Is it ok?

>     * libXcursor.spec: I'd like to remove the comments out #make -j1
>

The attached patch will hopefully fix these above comments ;-)

> ---+ dillo-2.1-fixb...truncation.path
>
> What does this patch do and why is it needed?
>

There is a issue on "htons(S->port)" when converting the port value to
big endian:

http.c: In function 'a_Http_dns_cb':
http.c:353: error: invalid 'asm': invalid operand for code 'w'

I found other people getting similar issue, but failed to fix it.

Then I used a solution found at here:
https://www.rocklinux.net/submaster/index.websplb?mode=patch&uid=2008101217562118489

This fix will limit Dillo to open only web pages on port 80 :-/

> ---+ dillo-2.1-fixfltk-flags.patch
>
> *NOTE* this is the one that worries me the most
>
> This seems to be hard wiring /usr/include /usr/lib, why?
>

Dillo is failing to find FLTK2 libraries, because it needs to run
"fltk2-config" on host system. Unfortunately FLTK2 is not officially
released, then Linux distros (including Fedora, Ubuntu, Debian, etc)
don't have it, they have only FLTK version 1.

I agree it is not a nice solution, but by now this is the easy and
best approach.

> ---+ fltk-2.-.x-fixt..ntcrash.patch
>
> Okay
>
>
> ---+ fltk-2.0.x-nofluid.patch
>
> Can this be achieve using an option to configure?
>
> What harm does leaving it in do.  That is what happens
> if you allow fluid to be installed, is this just an
> option to save space?
>

FLUID is the FLTK development IDE, I think nobody will use it on
target (embedded) side. Also again it will fail to install because it
can't to run "fltk2-config". I think removing it is not offensive :-)

>
> ---+ fltk-2.0.x-re...utdemos.patch
>
> Can this be achieve using an option to configure?
>

Well, these GLUT demos still trying to link against OpenGL although I
am configuring FLTK2 passing "--disable-gl". I removed them to fix
compilation since we don't have opengl support. (In fact i.MX31 has
OpenGL-ES support, but it is not open source until now and I think
mainline LTIB will not link against closed libs)

Please, let me know if everything is ok!?

Best Regards,

Alan

dillo2.patch
Description: Text Data