Re: [Ltib] [PATCH] Dillo2 Web Browser

[Stuart Hughes]

Hi Alan,

Thanks for re-factoring this, it made it much easier to look at in 
complete context.  It mostly looks okay, but I have a few comments and 
questions:

---+ dillo2.diff:

   * packages.lkc: I'd like to keep the indent for
     select clauses like others (formatting consistency)

   * fltk2.spec: I'd like Source: reference the 'rev' tag
     defined

   * libXcursor.spec: I'd like to remove the comments out #make -j1

---+ dillo-2.1-fixb...truncation.path

What does this patch do and why is it needed?

---+ dillo-2.1-fixfltk-flags.patch

*NOTE* this is the one that worries me the most

This seems to be hard wiring /usr/include /usr/lib, why?

---+ fltk-2.-.x-fixt..ntcrash.patch

Okay


---+ fltk-2.0.x-nofluid.patch

Can this be achieve using an option to configure?

What harm does leaving it in do.  That is what happens
if you allow fluid to be installed, is this just an
option to save space?


---+ fltk-2.0.x-re...utdemos.patch

Can this be achieve using an option to configure?

Regards, Stuart

Alan Carvalho de Assis wrote:
> Hi Stuart,
>
> Please, find attached the patch of spec files and each single patch to
> source code.
>
> I hope you accept it now.
>
> Best Regards,
>
> Alan