Re: [Ltib] [PATCH] Dillo2 Web Browser

[Alan Carvalho de Assis]

Hi Stuart,

On 7/15/09, Stuart Hughes <address@hidden> wrote:
> Hi Alan,
>
> I've cut back all the parts that are okay and just left the ones with
> questions remaining.
>

sic

>> There is a issue on "htons(S->port)" when converting the port value to
>> big endian:
>>
>> http.c: In function 'a_Http_dns_cb':
>> http.c:353: error: invalid 'asm': invalid operand for code 'w'
>>
>> I found other people getting similar issue, but failed to fix it.
>>
>> Then I used a solution found at here:
>> https://www.rocklinux.net/submaster/index.websplb?mode=patch&uid=2008101217562118489
>>
>> This fix will limit Dillo to open only web pages on port 80 :-/
>
> A proper fix for this is really needed.  Your patch would cause dillo to
> fail on little endian (that is removing htons).  Maybe adding
> parenthesis would work?  I think the issue is that htons is defined as
> an assembler macro and for some reason causes an exception.
>

I am using ARM on default endian (little endian), in fact it will not
fail because I leaved "htons(DILLO_URL_HTTP_PORT);"

I think it is failing because "->" in "htons(S->port)".

> See if you can find anything, if not I'll take a look when I try to
> apply all this.
>

I will try parenthesis and let you know.

>> Dillo is failing to find FLTK2 libraries, because it needs to run
>> "fltk2-config" on host system. Unfortunately FLTK2 is not officially
>> released, then Linux distros (including Fedora, Ubuntu, Debian, etc)
>> don't have it, they have only FLTK version 1.
>>
>> I agree it is not a nice solution, but by now this is the easy and
>> best approach.
>
> Okay I see.  What I'm worried about though is that these paths will
> cause dillo to internally use /usr/{include,lib} parts.
>

Hmm, sure.

>> Please, let me know if everything is ok!?
>>
>
> Okay for now let's go with what you have and improve later.
>
> I will try an apply this and make changes as I think are needed.  I will
> send you what I have back for comment before I commit it.
>

Great, thank you very much!

> Regards, Stuart
>

Best Regards,

Alan