Re: [Ltib] [PATCH] Dillo2 Web Browser

[Stuart Hughes]

Hi Alan,

I've cut back all the parts that are okay and just left the ones with 
questions remaining.

Alan Carvalho de Assis wrote:

> I solved it this way:
>
> Release         : r6793
> Source          : %{name}-%{version}-%{release}.tar.bz2
>
> Is it ok?

That's fine.


> > ---+ dillo-2.1-fixb...truncation.path
> >
> > What does this patch do and why is it needed?
>
> There is a issue on "htons(S->port)" when converting the port value to
> big endian:
>
> http.c: In function 'a_Http_dns_cb':
> http.c:353: error: invalid 'asm': invalid operand for code 'w'
>
> I found other people getting similar issue, but failed to fix it.
>
> Then I used a solution found at here:
> https://www.rocklinux.net/submaster/index.websplb?mode=patch&uid=2008101217562118489
>
> This fix will limit Dillo to open only web pages on port 80 :-/

A proper fix for this is really needed.  Your patch would cause dillo to 
fail on little endian (that is removing htons).  Maybe adding 
parenthesis would work?  I think the issue is that htons is defined as 
an assembler macro and for some reason causes an exception.

See if you can find anything, if not I'll take a look when I try to 
apply all this.


> > ---+ dillo-2.1-fixfltk-flags.patch
> >
> > *NOTE* this is the one that worries me the most
> >
> > This seems to be hard wiring /usr/include /usr/lib, why?
>
> Dillo is failing to find FLTK2 libraries, because it needs to run
> "fltk2-config" on host system. Unfortunately FLTK2 is not officially
> released, then Linux distros (including Fedora, Ubuntu, Debian, etc)
> don't have it, they have only FLTK version 1.
>
> I agree it is not a nice solution, but by now this is the easy and
> best approach.

Okay I see.  What I'm worried about though is that these paths will 
cause dillo to internally use /usr/{include,lib} parts.


> > ---+ fltk-2.0.x-re...utdemos.patch
> >
> > Can this be achieve using an option to configure?
>
> Well, these GLUT demos still trying to link against OpenGL although I
> am configuring FLTK2 passing "--disable-gl". I removed them to fix
> compilation since we don't have opengl support. (In fact i.MX31 has
> OpenGL-ES support, but it is not open source until now and I think
> mainline LTIB will not link against closed libs)
>
> Please, let me know if everything is ok!?

Okay for now let's go with what you have and improve later.

I will try an apply this and make changes as I think are needed.  I will 
send you what I have back for comment before I commit it.

Regards, Stuart