[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW]
From: |
Kieran Mansley |
Subject: |
Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW] |
Date: |
Tue, 11 Aug 2009 15:51:22 +0100 |
On Tue, 2009-08-11 at 16:45 +0200, address@hidden wrote:
> Kieran Mansley wrote:
> > One thing I noticed was the way it calls tcp_sent() to specify the
> > callback every time it does a write is harmless but not a good example -
> > it should only need to be called once to set the callback up.
> >
> It does? As I see it, tcp_sent() is only called once - after receiving
> the request. And since it does not implement keepalive, this can only
> happen once per pcb (also guarded by if (hs->file == NULL) in http_recv).
My mistake, sorry. I'd still rather see it specified as part of the
connection setup. I wonder if the current code could send it all before
send_data() returned and tcp_sent() is called, and so never call the
sent callback because it was NULL when the data were written and ACKed.
Unlikely perhaps, but still not a great example.
Kieran
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], (continued)
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], address@hidden, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Chris Strahm, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Jeff Barber, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Chris Strahm, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], address@hidden, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Chris Strahm, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Kieran Mansley, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], address@hidden, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Kieran Mansley, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], address@hidden, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW],
Kieran Mansley <=
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Chris Strahm, 2009/08/11
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], address@hidden, 2009/08/11
- RE: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Bill Auerbach, 2009/08/12
- RE: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Simon Goldschmidt, 2009/08/12
- RE: [lwip-users] Improved HTTP webserver (was: http_sent cb shows 1 byte trailer [RAW]), Bill Auerbach, 2009/08/12
- RE: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Pettinato, Jim, 2009/08/12
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Jeff Barber, 2009/08/10
- Re: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Kieran Mansley, 2009/08/11
- RE: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Ben Hastings, 2009/08/10
- RE: [lwip-users] http_sent cb shows 1 byte trailer [RAW], Kieran Mansley, 2009/08/11