Re: [Maposmatic-dev] [PATCH 1/2] forms: translate stylesheet and layout descriptions, and paper sizes

[David MENTRE]

Hello,

2012/4/3 Thomas Petazzoni <address@hidden>:
> -        self.fields['stylesheet'].choices = [(s.name, s.description)
> -                                             for s in stylesheets]
> +        for s in stylesheets:
> +            if s.name == "Default":
> +                description = _("The default OpenStreetMap.org style")
> +            elif s.name == "MapQuestEu":
> +                description = _("The european MapQuest style")
> +            elif s.name == "MapQuestUs":
> +                description = _("The US MapQuest style")
> +            elif s.name == "MapQuestUk":
> +                description = _("The UK MapQuest style")
> +            elif s.name == "Printable":
> +                description = _("A MapOSMatic-specific stylesheet suitable 
> for printing")

Regarding this part, we should probably put a note somewhere that the
names listed in above list (Default, MapQuestEu, ...) should be the
same name as ocitysmap configuration. Maybe a comment in *both*
ocitysmap configuration template and just before above code.

Your current patch is not fully satisfying (fragile dependency between
ocitysmap.conf and above code)  but currently I don't see any other
way to improve it (I need to digest the discussion on the subject).
With your current patch, at least this is not a blocking issue for
production.

Best regards,
d.