Re: [Mingw-cross-env-list] Missing libmng dependency on lcms

[David García Garzón]

A Dijous 11 Novembre 2010 02:31:39, Mark Brand va escriure:
> On 11/11/2010 01:24 AM, Volker Grabsch wrote:
> > David García Garzón<address@hidden>  schrieb:
> >> On Tuesday 09 November 2010 23:23:44 Mark Brand wrote:
> >>> I took a quick look at this. According to libmng's  README.config ,
> >>> libmng can use lcms. But the "lcms" in mingw-cross-env is actually
> >>> lcms2 which does not work. Apparently, the older lcms would need to 
be
> >>> added to mingw-cross-env, or perhaps libmng could be made to work 
with
> >>> lcms2. Are you interested in pursuing one of the options?
> >> 
> >> [...]
> >> 
> >> Try compiling just libmng from a clean installation. The compilation
> >> fails complaining about lcms. Compile lcms2 (the same version in
> >> cross-mingw-env) first and it will compile with no modification (no
> >> need for lcms1). I guess that usually lcms2 gets compiled previously in
> >> the build sequence and because of that it gave no problem until now.
> > 
> > So your analysis seems contradict that of Mark.
> > 
> > Mark, David, it would be great if you could clarify whether lcms1 is
> > needed or not. (i.e. whether the current lcms(2) is sufficient or not)
> 
> Libmng would build fine with "make libmng" on a clean mingw-cross-env
> installation, however that was without lcms support. With MNG_FULL_CMS
> defined, libmng requires lcms.h which of course is neither on a clean
> installation nor supplied by lcms2.
> 
> Lcms2 supplies lcms2.h, but this header is mentioned nowhere in
> libmng-1.0.10.  Even renamed to lcms.h, it is not compatible with libmng.
> 
> David's report is puzzling to me. He didn't say whether he had defined
> MNG_FULL_CMS, so that might be part of the explanation.
> 
> Since there was no lcms dependency for our libmng built without
> MNG_FULL_CMS, I interpreted David's original post as a request for lcms
> support in libmng. My commit adds "-DMNG_FULL_CMS" to libmng and adds
> the project "lcms1":
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/aef0ad263e19
> 
> With these changes libmng builds successfully with lcms support and
> seems to work fine. David, I'm curious to know if it works for you now too.
> 
> regards,
> 
> Mark

I reviewed what i did and you are right. i 'successfully' compiled and linked 
libmng against lcms2 but it was totally disabled because that macro wasn't 
defined. As soon as i define such a macro, compilation fails because missing 
libcms.h. So ignore my previous messages and drop, if you want lcms1. I 
don't specially need it. My apologizes for the confusion.

- 
David García Garzón
(Work) david dot garcia at upf anotherdot edu
http://www.iua.upf.edu/~dgarcia