mingw-cross-env-list
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Mingw-cross-env-list] Preparation of Release 2.17


From: Tony Theodore
Subject: Re: [Mingw-cross-env-list] Preparation of Release 2.17
Date: Sun, 5 Dec 2010 22:40:43 +1100

On 5 December 2010 01:52, Volker Grabsch <address@hidden> wrote:
> Tony Theodore <address@hidden> schrieb:
>> On 4 December 2010 08:09, Volker Grabsch <address@hidden> wrote:
>> > So you should find its definition in some *.m4
>> > file. It would be great if you could have a look at that, and
>> > fix the issue there, at the source of the issue.
>>
>> Thanks, now I know where to look. I try very hard to avoid
>> auto[re]conf - on my own machines I can have many versions and this
>> seems to be a very recent one. As a general guideline - should we
>> patch "configure", or should we try to autoconf?
>
> It depends.
>
> For ugly hacks, patching the ./configure script provides more
> freedom, makes things easier and avoids the possible trouble
> caused by running the autotool over it.
>
> However, when a clean, portable fix is possible, it should
> be done in the sources, i.e. in the configure.ac, Makefile.am
> or *.m4 files as appropriate. The hassle of running the autotools
> will be compensated if the bugfix is acceped by upstream.

This has already been fixed upstream:
https://bugzilla.gnome.org/show_bug.cgi?id=636267
https://bugzilla.gnome.org/show_bug.cgi?id=636268

and the minimum autoconf version is 2.60 (below our requirements), so
I've just used
the upstream changes with a note to remove the autoconf call at the
next release:

http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/4ecbbfae4aee
http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/676e3b177b03

This is working on FreeBSD, OSX, and Ubuntu and there are no further
issues here.

Cheers,

Tony



reply via email to

[Prev in Thread] Current Thread [Next in Thread]