monotone-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-devel] [PATCH] mtn commit without -b and mtn branch


From: Derek Scherger
Subject: Re: [Monotone-devel] [PATCH] mtn commit without -b and mtn branch
Date: Sun, 11 Mar 2007 23:48:57 -0600
User-agent: Thunderbird 1.5.0.10 (X11/20070304)

> Nathaniel Smith wrote:
>> chkeypass, genkey: These are real commands, but they could sure have
>>   better names.  For chkeypass, perhaps 'passphrase' (cf. passwd(1))?

I've made this change on mainline.

>>   Suggestion: teach the command parsing code to simply replace all
>>   underscores with hyphens when it is figuring out the names of
>>   commands :-).  (They have to stay underscores internally because
>>   they turn into C++ symbol names, but it's easy to munge the string
>>   on its way into the command line parsing tables.)

Also, I've pushed nvm.experiment.commands-with-dashes that does this.
There's a couple of things to note though.

1. It's endlessly debatable as to whether we should do this for the
automate commands or not. I chose to do it, but added backward
compatibility support for the old command names so that scripts won't
break immediately. Presumably we will force the issue some day and bump
interface_version when we do.

2. I noticed several automate commands that are either (a) *untested* or
(b) *undocumented* or (c) *both* which doesn't strike me as a good
thing. So, if anyone has a favorite automate command, perhaps go and
check that it appears in monotone.texi and the testsuite.

Cheers,
Derek





reply via email to

[Prev in Thread] Current Thread [Next in Thread]