[Octave-bug-tracker] [bug #40436] median no longer passes make check

[John W. Eaton]

Follow-up Comment #48, bug #40436 (project octave):

Looking at bits/stl_algo.h, it seems that the affected functions, two
variations of __unguarded_partition_pivot, are ultimately used in both
std::nth_element and std::sort.  We use both in Octave.

Would it be better to replace the bits/stl_algo.h file when building Octave
(can easily be done by putting a modified file in the Octave source tree and
finding it with a -I compiler flag) or should we just provide replacements for
std::sort and std::nth_element?  Or should we just fail to build Octave if
this bug is found and tell people they need to install a version of GCC that
does not have this problem?

I hesitate to install a fix in Octave (either replacing the header file or the
functions) because we'll likely have to carry this baggage around for years to
come.  If we just refuse to build, we'll be pushing people in the direction of
fixing the problem.  And the fix is trivial and doesn't even require
rebuilding the compiler.


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40436>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/