[Octave-bug-tracker] [bug #41027] config.h is too generic

[John W. Eaton]

Follow-up Comment #22, bug #41027 (project octave):

I've checked in a series of changesets that have removed many of the
configuration macros from our public header files.  For macros and typedefs
that can't be removed, I created a new octave-config.h header.  That file is
installed now.  I think I'm close to the point where it's no longer necessary
to install config.h.

I'm not sure about the following:

Should we just require that anyone wishing to use Octave headers include
octave-config.h?  Or should all of our headers that need it include it?  That
would be almost all of them since nearly every header needs a typedef for
octave_idx_type or OCTAVE_API (the dllimport/visibility attribute tag).

Similarly, should all header files include all the other headers they need?  I
guess so, since that's something that needs to happen anyway and we have
multiple inclusion guards on almost every file now (and it wouldn't be too
hard to make sure that we have them on all header files).

The big remaining issues are dealing with FFTW, LLVM, and libz, as the classes
that we have that use these features expose details of the various library
interfaces in our public interfaces.  I've already cleaned up a lot of this
kind of thing but I'm not sure yet how to deal with these remaining problems. 


Even though a few things still need to be fixed, I think the Octave header
files are significantly cleaner now.  So, progress anyway.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?41027>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/