|
From: | John W. Eaton |
Subject: | Re: GUI won't build with older QScintilla |
Date: | Fri, 05 Apr 2013 16:18:25 -0400 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:10.0.11) Gecko/20121122 Icedove/10.0.11 |
On 04/05/2013 03:58 PM, Jordi Gutiérrez Hermoso wrote:
However, are you sure you like the overall direction of this patch? I'm not opposed to using newer features of QScintilla, and you don't need to duplicate the QsciLexerOctave class in Octave. The duplication, if that's what it is, seems very small, so perhaps it's ok.
It would be OK to make it so that the feature is just not available unless you have a newer version of QScintilla. I think that would be better than trying to duplicate the missing feature.
jwe
[Prev in Thread] | Current Thread | [Next in Thread] |