Re: [Qemu-devel] Makefile question

[Anthony Liguori]

C.W. Betts wrote:
> I have made
> On Sep 25, 2008, at 2:53 PM, Robert Riebisch wrote:
>
> > Anthony Liguori wrote:
> >
> > > Where does the object file come from?
> >
> > Generated from .rc by `windres'.
> I have made a patch that uses windres to identify the version number 
> of the app.  The patch is in the attachments.  Perhaps you can get 
> some pointers from it.
>
> Index: Makefile.target
> ===================================================================
> --- Makefile.target    (revision 5321)
> +++ Makefile.target    (working copy)
> @@ -661,6 +665,7 @@
>  
>  ifdef CONFIG_WIN32
>  SDL_LIBS := $(filter-out -mwindows, $(SDL_LIBS)) -mconsole
> +OBJS+=version.o
>  endif
>  
>  # profiling code
> @@ -676,6 +681,9 @@
>  
>  %.o: %.c
>      $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $<
> +   
> +%.o: %.rc
> +    windres -I. -DORIGINAL_FILENAME=\"$(QEMU_PROG)\" -c -o $< $@

This needs to be ${cross_prefix}windres

>  %.o: %.S
>      $(CC) $(CPPFLAGS) -c -o $@ $<
> Index: configure
> ===================================================================
> --- configure    (revision 5321)
> +++ configure    (working copy)
> @@ -1319,6 +1319,10 @@
>  echo "# Automatically generated by configure - do not modify" > 
> $config_mak
>  echo "/* Automatically generated by configure - do not modify */" > 
> $config_h
>  
> +if test "$mingw32" = "yes" ; then
> +echo "#define QEMU_FILEVERSION $(tr . , < $source_path/VERSION),0" >> 
> $config_h
> +echo "#define QEMU_PRODUCTVERSION $(tr . , < $source_path/VERSION),0" 
> >> $config_h
> +fi

You could just use QEMU_VERSION in the .rc file

I think it's a good idea to include a default .rc file for the QEMU 
Windows build.  If you update the patch, I'd be happy to apply it.

Regards,

Anthony Liguori