Re: [Qemu-devel] TCG on PowerPC arch

[Andreas Färber]

Hi,

Am 27.10.2008 um 16:29 schrieb Salvatore Lionetti:

> - Activity [major fix] {vl.c hw/ppc.c}
>  reset: unprogram PIT on chip, core, system reset
>  focus: initial focus in monitor when load very great sized elf
>
> I try to attach to svn view.

Not sure I understand correctly, but this last item seems to be  
missing here.
It would be good if you could check whether your patches still apply  
against the latest SVN version, if that's what you meant with the  
latter.
ppc hardware probably hasn't changed so much since 0.9.1 but pflash  
might have.

> +static uint32_t emac_readw (void *opaque, target_phys_addr_t addr)
> +{
> +       printf("Lettura a granularita' word su EMAC " PADDRX "\n",addr);
> +       return 0;
> +}

Some Italian slipped in here, also in some comments.
Is the printf maybe a debug leftover that could be removed?

The split-up of your original patch looks okay, but for future  
submissions it would make review easier if you'd send only one of them  
at a time (e.g., mail subjects [PATCH 1/3], [PATCH 2/3] etc., see  
other examples).

How did you actually use and test your eMac emulation? I assume you  
did not use a PReP Linux kernel for that? If you could provide some  
details, that might help with testing the TCG conversion too.

Andreas