Re: [Qemu-devel] TCG on PowerPC arch

[Salvatore Lionetti]

Ok,

thanks for your review!
Perhaps there was a lot of point to change and in the case, do it!
One of this is adding emac module in 'Makefile.target' (i forgot it!), but i 
think you just patch the patch !#
For the italian comment, if it is necessary behead it, or better: globalize it 
;)

Serious speaking we have to see at EBC and emulates hw by composing or filter 
readed byte from device. Should be useful an on demand warning per device(in my 
board fw address@hidden different from the preset in EBC Bank-i configuration 
register bits 17:18 is considered a bug)
All this action should be done for the ppc4xx world.
In the mainwhile, for me, you can do anything you want about this read/write 
callback. On demand i'll adapt the code.

For me the main pb, due to my unknowing, is that i'm behind a proxy on Winzozz 
and svn give me timeout. Is the follow command correct?
->svn co svn://svn.sv.gnu.org/qemu/trunk

Next time i prefer also test latest svn before submit a patch, in the same way 
we address@hidden, avoiding unecessary work to this group.

I'm here for any pb related to this module
Thank you for attention
Salvatore

P.S: For the board, it is a commercial product so don't know if can give 
detail. Moreover i don't thing you need the exact board so, if agree, i create 
a new board from the previous.

P.P.S: In this board there is a way to configure qemu by file. I'd like to 
extent such concept, with correct namespace, configuration option.


--- Mar 28/10/08, Andreas Färber <address@hidden> ha scritto:

> Da: Andreas Färber <address@hidden>
> Oggetto: Re: [Qemu-devel] TCG on PowerPC arch
> A: address@hidden
> Cc: address@hidden
> Data: Martedì 28 ottobre 2008, 21:41
> Hi,
> 
> Am 27.10.2008 um 16:29 schrieb Salvatore Lionetti:
> 
> > - Activity [major fix] {vl.c hw/ppc.c}
> >  reset: unprogram PIT on chip, core, system reset
> >  focus: initial focus in monitor when load very great
> sized elf
> >
> > I try to attach to svn view.
> 
> Not sure I understand correctly, but this last item seems
> to be  
> missing here.
> It would be good if you could check whether your patches
> still apply  
> against the latest SVN version, if that's what you
> meant with the  
> latter.
> ppc hardware probably hasn't changed so much since
> 0.9.1 but pflash  
> might have.
> 
> > +static uint32_t emac_readw (void *opaque,
> target_phys_addr_t addr)
> > +{
> > +   printf("Lettura a granularita' word su EMAC
> " PADDRX "\n",addr);
> > +   return 0;
> > +}
> 
> Some Italian slipped in here, also in some comments.
> Is the printf maybe a debug leftover that could be removed?
> 
> The split-up of your original patch looks okay, but for
> future  
> submissions it would make review easier if you'd send
> only one of them  
> at a time (e.g., mail subjects [PATCH 1/3], [PATCH 2/3]
> etc., see  
> other examples).
> 
> How did you actually use and test your eMac emulation? I
> assume you  
> did not use a PReP Linux kernel for that? If you could
> provide some  
> details, that might help with testing the TCG conversion
> too.
> 
> Andreas


      Unisciti alla community di Io fotografo e video, il nuovo corso di 
fotografia di Gazzetta dello sport:
http://www.flickr.com/groups/iofotografoevideo