[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm |
Date: |
Wed, 12 Aug 2015 10:00:41 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 |
On 08/09/2015 01:13 PM, Laurent Vivier wrote:
> Signed-off-by: Laurent Vivier <address@hidden>
> ---
> target-m68k/translate.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/target-m68k/translate.c b/target-m68k/translate.c
> index ae57792..adf4521 100644
> --- a/target-m68k/translate.c
> +++ b/target-m68k/translate.c
> @@ -2002,6 +2002,24 @@ DISAS_INSN(eor)
>
> opsize = insn_opsize(insn, 6);
>
> + if (((insn >> 3) & 7) == 1) {
> + /* cmpm */
Surely this can be separated out from EOR via masks at register_opcode time.
And since this isn't a coldfire instruction...
> + reg = AREG(insn, 0);
> + src = gen_load(s, opsize, reg, 1);
> + tcg_gen_addi_i32(reg, reg, opsize_bytes(opsize));
> +
> + reg = AREG(insn, 9);
> + dest = gen_load(s, opsize, reg, 1);
> + tcg_gen_addi_i32(reg, reg, opsize_bytes(opsize));
> +
> + reg = tcg_temp_new();
> + tcg_gen_sub_i32(reg, dest, src);
> + gen_update_cc_add(reg, src);
No need for the extra temp, reg. Simply modify dest.
> + SET_CC_OP(opsize, SUB);
> +
> + return;
> + }
> +
> SRC_EA(env, src, opsize, -1, &addr);
> reg = DREG(insn, 9);
> dest = tcg_temp_new();
>
- [Qemu-devel] [PATCH for-2.5 18/30] m68k: addq/subq can work with all the data sizes., (continued)
- [Qemu-devel] [PATCH for-2.5 18/30] m68k: addq/subq can work with all the data sizes., Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 16/30] m68k: Add all access modes and data sizes to some 680x0 instructions, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 20/30] m68k: add exg, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 21/30] m68k: add bkpt, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm, Laurent Vivier, 2015/08/09
- Re: [Qemu-devel] [PATCH for-2.5 19/30] m68k: add cmpm,
Richard Henderson <=
- [Qemu-devel] [PATCH for-2.5 25/30] m68k: add abcd, sbcd, nbcd instructions, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 24/30] m68k: add DBcc and Scc (memory operand), Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 22/30] m68k: add cas instruction, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 23/30] m68k: add linkl, Laurent Vivier, 2015/08/09
- [Qemu-devel] [PATCH for-2.5 27/30] m68k: add addx/subx/negx, Laurent Vivier, 2015/08/09