qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs a


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH 1/3] checkpatch: tweak the files in which TABs are checked
Date: Wed, 10 Aug 2016 10:06:41 +0800
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, 08/09 17:47, Paolo Bonzini wrote:
> Include Python and shell scripts, and make an exception for Perl
> scripts we imported from Linux or elsewhere.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  scripts/checkpatch.pl | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index b7cb4ab..7ccf6a8 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1351,8 +1351,10 @@ sub process {
>                       WARN("adding a line without newline at end of file\n" . 
> $herecurr);
>               }
>  
> -# check we are in a valid source file C or perl if not then ignore this hunk
> -             next if ($realfile !~ /\.(h|c|cpp|pl)$/);
> +# check we are in a valid source file; if not then tabs are allowed.
> +# make an exception from some scripts imported from other projects.

s/from some/for some/ ?

> +             next if ($realfile !~ /\.(h|c|cpp|pl|py|sh)$/);
> +             next if ($realfile =~ 
> /(checkpatch|get_maintainer|texi2pod)\.pl$/);
>  
>  # in QEMU, no tabs are allowed
>               if ($rawline =~ /^\+.*\t/) {
> -- 
> 2.7.4
> 
> 
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]