qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular


From: Daniel P. Berrange
Subject: Re: [Qemu-devel] [PATCH v2 02/47] trace: switch io/ directory to modular trace.h file
Date: Wed, 11 Jan 2017 10:28:32 +0000
User-agent: Mutt/1.7.1 (2016-10-04)

On Tue, Jan 10, 2017 at 10:01:12PM +0100, Paolo Bonzini wrote:
> 
> 
> On 10/01/2017 19:36, Daniel P. Berrange wrote:
> > 
> > It seems you're saying we should also trim the top level dirs, so
> > we in fact get:
> > 
> > 
> > -I/home/berrange/src/virt/qemu/hw/scsi
> > -Ihw/scsi
> > -I/home/berrange/src/virt/qemu/tcg
> > -I/home/berrange/src/virt/qemu/tcg/i386
> > -I/home/berrange/src/virt/qemu/linux-headers
> > -I/home/berrange/src/virt/qemu-build/linux-headers
> > -I/home/berrange/src/virt/qemu/include
> 
> Yes, and ultimately tcg too.

So the problem with dropping BUILD_DIR from the include path is that
config-host.h is generated in that location. We'll have to move that
into BIULD_DIR/include and add -I$(BUILDDIR)/include to search path
instead.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://entangle-photo.org       -o-    http://search.cpan.org/~danberr/ :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]