|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 19/28] target/riscv: Replace gen_branch() with trans_branch() |
Date: | Sat, 13 Oct 2018 12:39:58 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 10/12/18 10:30 AM, Bastian Koppelmann wrote: > +static bool trans_branch(DisasContext *ctx, arg_branch *a, TCGCond cond) I think you should still call it gen_branch. Reserve the trans_ prefix for things called from the decoder. Otherwise, Reviewed-by: Richard Henderson <address@hidden> r~
[Prev in Thread] | Current Thread | [Next in Thread] |