Re: [Quilt-dev] [patch] Quilt support for committing patches to CVS.

[Joe Green]

Dean Roehrich wrote:
> > The second attachment shows 
> > a set of .quiltrc functions that support CVS operations in the same way 
> > as my previous integrated patch.
>
> Should the realfile function be handled within quilt?  I'm not clear on why
> this function is necessary.

In the past there has been support for having the SERIES variable point 
to a symlink to the series file instead of the real thing.  For CVS 
operations the real file is needed.

> Maybe new_series=yes should instead be set here:
>
>         else
>                 echo "$patch$patch_args" > $tmpfile
>                 if [ -e $SERIES ]
>                 then
>                         cat $SERIES >> $tmpfile
>                 else
>                         new_series=yes
>                 fi
>         fi

That's OK with me.

> Nothing in delete.in actually unlinks the patchfile.  So it stays in the
> patches directory.  By telling an scm to delete it we may be causing an unlink
> to happen (depending on the scm), and that would lead to an unexpected side
> effect.

Yes, that's how we use it locally, so that's the functionality I left 
in.  (My CVS hooks move the file to "file~" rather than removing it.) 
You're right that normally quilt doesn't do this.  I should probably 
support this by adding a "remove patch file" option to delete, and only 
call the delete hook in that case.

--
Joe Green <address@hidden>
MontaVista Software, Inc.