Re: [Quilt-dev] [patch 1/8]

[John Vandenberg]

On 9/14/05, Jean Delvare <address@hidden> wrote:
> 
> Hi Gary,
> 
> (Could you please fix your "From:" field when sending mails? The lack
> of space between ">" and "(" seems to confuse my webmail client a
> lot. I tend to think that addresses are better spelled "Foo Bar
> <address@hidden>" than "<address@hidden> (Foo Bar)" anyway, don't
> you?)
> 
> [Gary V. Vaughan]
> > In Mac OS X 10.4 (I run 10.4.2) the chmod command doesn't understand the
> > `--reference' option. Darwin ports provides a build of coreutils, but
> > installs it as gchmod.
> 
> I have the same problem with Solaris 8, those chmod doesn't understand
> --reference either.
> 
> > This patch replaces the one offending chmod invocation with a shell if
> > statement that is much more portable, and saves the trouble of installing
> > coreutils especially.
> 
> +1
> 
> But I would go one step beyond and ask what this chmod is useful for.
> "install" will later set the permissions properly anyway, so the only
> benefit seems to be for pre-install execution, which won't work for
> initial installations anyway because the path to patchfns is hardcoded
> in each quilt command script. So the benefit is very thin and probably
> not worth the trouble, so I would propose that we simply get rid of that
> chmod command.
> 
> This will also let us get rid of the +x on .in files, which was a
> nonsense anyway because most of these files were actually not executable
> (because they use @FOO@ in various places).
> 
> Thoughts anyone?

Removing the line has my vote.

afaics, the +x can be removed from these files in CVS without
affecting earlier releases.  The line in question comes from v1.1 of
Makefile.in, and even back that far, "make install" used BSD install,
setting the permissions.

--
John