Re: [Quilt-dev] [patch 1/8]

[Gary V. Vaughan]

John Vandenberg wrote:
> On 9/14/05, Jean Delvare <address@hidden> wrote: 
> > Hi Gary,

Hi John, Jean, Quilters ;-)

> > (Could you please fix your "From:" field when sending mails? The lack
> > of space between ">" and "(" seems to confuse my webmail client a
> > lot. I tend to think that addresses are better spelled "Foo Bar
> > <address@hidden>" than "<address@hidden> (Foo Bar)" anyway, don't
> > you?)

I was being paranoid about whether quilt mail would be able to pass
'"Gary V. Vaughan" <address@hidden>' through to sendmail
without molesting the quotes.  (Incidentally, there are several bugs
in mail.in... I might post patches if I try to use it again)

> > [Gary V. Vaughan]
> > > In Mac OS X 10.4 (I run 10.4.2) the chmod command doesn't understand the
> > > `--reference' option. Darwin ports provides a build of coreutils, but
> > > installs it as gchmod.
> >
> > I have the same problem with Solaris 8, those chmod doesn't understand
> > --reference either.
> >
> >
> > > This patch replaces the one offending chmod invocation with a shell if
> > > statement that is much more portable, and saves the trouble of installing
> > > coreutils especially.
> >
> > +1
> >
> > But I would go one step beyond and ask what this chmod is useful for.
> > "install" will later set the permissions properly anyway, so the only
> > benefit seems to be for pre-install execution, which won't work for
> > initial installations anyway because the path to patchfns is hardcoded
> > in each quilt command script. So the benefit is very thin and probably
> > not worth the trouble, so I would propose that we simply get rid of that
> > chmod command.

Okay, agreed.  I was going for smallest amount of code churn to maximise
chances of upstream merge... Update inline below.

> > This will also let us get rid of the +x on .in files, which was a
> > nonsense anyway because most of these files were actually not executable
> > (because they use @FOO@ in various places).

> afaics, the +x can be removed from these files in CVS without
> affecting earlier releases.  The line in question comes from v1.1 of
> Makefile.in, and even back that far, "make install" used BSD install,
> setting the permissions.

Nope, sorry, CVS doesn't version file permissions.  They will be forever
+x if commited that way unless someone with admin access to the server
manually removes the bit on ,v files :-(

Cheers,
        Gary.
--
Gary V. Vaughan      ())_.  address@hidden,gnu.org}
Research Scientist   ( '/   http://tkd.kicks-ass.net
GNU Hacker           / )=   http://www.gnu.org/software/libtool
Technical Author   `(_~)_   http://sources.redhat.com/autobook

In Mac OS X 10.4 (I run 10.4.2) the chmod command doesn't understand the
`--reference' option. Darwin ports provides a build of coreutils, but
installs it as gchmod.  Install sets the permissions properly later
anyway.

This patch removes the one offending chmod invocation, which saves the
trouble of installing coreutils.

 Makefile.in |    1 -
 1 files changed, 1 deletion(-)
Index: quilt-HEAD/Makefile.in
===================================================================
--- quilt-HEAD.orig/Makefile.in
+++ quilt-HEAD/Makefile.in
@@ -227,7 +227,6 @@ $(PACKAGE).spec : $(PACKAGE).spec.in $(P
             -e 's:@LOCALEDIR''@:$(localedir):g' \
             -e 's:@DOCSUBDIR''@:$(docdir)/$(PACKAGE)-$(VERSION):g' \
             $< > $@
-       @chmod --reference=$< $@

 Makefile : Makefile.in
        @echo "Please run ./configure by hand"