Re: [Quilt-dev] [PATCH] user-definable tail and grep

[Andreas Gruenbacher]

On Friday 16 September 2005 00:05, Gary V. Vaughan wrote:
> The normal approach is to allow the script user to override paths to
> particular commands in the environment.  I was quite surprised to
> see @COMMAND@ substitution hard coding scattered across the code rather
>
> than something like this at the top of patchfns:
> : ${TAIL="@TAIL@"}
>
> Then for the rest of the scripts:
>
> "$TAIL" -n 42 ...
>
> Is this just an oversight?  Or is there a reason for that design?

What's the benefit of "$TAIL" over @address@hidden (I'd rather use $TAIL 
without 
quotes to allow passing in arguments/etc, too.) IMHO it's a mess either way, 
and once we have @FOO@ substitutions we can as well replace them all over the 
place.

On the other hand, adding a directory to the front of path in patchfns would 
allow us to get rid of most @address@hidden in the scripts.

-- Andreas.