quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH] user-definable tail and grep


From: Jean Delvare
Subject: Re: [Quilt-dev] [PATCH] user-definable tail and grep
Date: Mon, 19 Sep 2005 19:58:46 +0200

Quoting myself:

> > In principle the patches look okay to me. We don't need to test for
> > grep ``-v'' though I think: AFAIK it's a pretty standard flag. Not
> > sure about ``-E'' and ``-q'': they are defined POSIX -- where don't
> > they exist?
> 
> All grep binaries I've seen support both -v and -q.

I have to correct what I said here: Solaris' /usr/bin/grep doesn't
support -q. So I would like to add this test back in configure.ac (my
original test was probably broken BTW, or I would have noticed earlier).

Additionally, configure.ac itself uses grep -q in several places, which
breaks on Solaris. There are two approaches to workaround this:

1* Test grep -q first, and use $GREP after that.

2* Replace uses of grep -q with grep >/dev/null 2>&1.

What's the prefered way?

Thanks,
-- 
Jean Delvare




reply via email to

[Prev in Thread] Current Thread [Next in Thread]