quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] [PATCH] user-definable tail and grep


From: Andreas Gruenbacher
Subject: Re: [Quilt-dev] [PATCH] user-definable tail and grep
Date: Sun, 18 Sep 2005 18:05:36 +0200
User-agent: KMail/1.7.1

On Sunday 18 September 2005 17:35, Jean Delvare wrote:
> Hi Andreas,
>
> > In principle the patches look okay to me. We don't need to test for
> > grep ``-v'' though I think: AFAIK it's a pretty standard flag. Not
> > sure about ``-E'' and ``-q'': they are defined POSIX -- where don't
> > they exist?
>
> All grep binaries I've seen support both -v and -q. I thought we could
> still test them as it doesn't cost us much, but I can drop these tests
> if you think they are needless.

I'd rather not add totally useless tests. The will just bitrot and break.

> Solaris' /usr/bin/grep doesn't support -E, so I really want this test in
> quilt's configure.

It's easy to not use ``grep -E'' at all. There were only a few instances, so 
we don't need this test anymore.

Thanks,
Andreas.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]