quilt-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Quilt-dev] Permanent target in Makefile


From: John Vandenberg
Subject: Re: [Quilt-dev] Permanent target in Makefile
Date: Wed, 21 Sep 2005 07:24:30 +1000

On 9/21/05, Jean Delvare <address@hidden> wrote:
> Hi John,
> 
> > cp: cannot stat `fn:p:h': No such file or directory
> > Failed to import patch fn:p:h
> 
> This is typical of a non-working getopt when trying to build the
> documentation file from quilt commands' -h output.
> 
> > compat-cleanup-1.diff
> >    Andreas patch sans two blocks
> >
> > compat-cleanup-2.diff
> >    merges the install rules into one
> 
> I'll let Andreas deal with these.
> 
> > compat-without.diff
> >    permit --without, and complain on invalid use of --with
> 
> Looks promising, I'm willing to commit this. Two comments though:
> 
> 1* Is it possible to also complain of the use of non-existent
> --with-foo options? I've been frustrated a number of times by typos in
> these options already.

Not easily, and definitely not in a stable manner; it would need to be
intrusive into the autoconf generated portions of the configure
script.  If would be of assistance, I wrote a bash completion script a
few years ago that lists the configure options available after
'./configure <TAB><TAB>'.  There are a few tools to do this now;
sourceinstall is one I have looked at.

> 2* Could you make it so that the use of --without-foo doesn't cause a
> WARNING? The user asked for it, there is no reason to warn about
> anything.

Im not keen on this; this implies that the compatibility programs are
going to work, and the config.log needs to flag this problem.  You
raise a valid point though.  the configure output isn't up to scratch;
if I may, rather than check that patch in, I'd like to have another
swing at that macro.  ( Andreas, is it ok if I put it in m4/compat.m4
? )

> > local-quilt.diff
> >    build doc's with "QUILT_DIR=. ./bin/quilt $cmd -h "
> >
> > The last patch replaces @SCRIPTS@ with $QUILT_DIR/scripts in order to
> > reduce the number of substitutions to be carried around; is that
> > acceptable, or do some platforms install scripts in a different
> > directory ?

--
John




reply via email to

[Prev in Thread] Current Thread [Next in Thread]