Re: [Quilt-dev] Re: ftw removed; emacs mode; translations; ready for 0.43?

[John Vandenberg]

Hi Andreas, Jean,

Sorry that this is arriving after the release...

On 02/02/06, Andreas Gruenbacher <address@hidden> wrote:
> On Thursday 02 February 2006 07:54, John Vandenberg wrote:
> > I have found a few minor issues today ..
> >
> > * configure.ac uses grep -q instead of $GREP -q in the patch check.
> > * There is no checks in place to prevent Sun diff from being used.
> >
> > The attached patch addresses those two.
>
> Can you commit that?

committed with a minor change to catch the various places that the
version number appears in the first line in different versions.

> > * Solaris /usr/xpg4/bin/awk fails in mail.in.
> >
> > Instead of introducing change at this stage, can we simply remove the
> > recommendation from the configure output?
>
> Probably a good idea, yes. It would be interesting to know what fails though.

The attached patch fixes the problem.

> I would also like to change the way how parameters are currently passed to awk
> in many places in one of the next steps, like this:
>
>                 awk '
> -               $0 == "'"$patch"'"      { exit }
> -                                       { print }
> -               ' $DB
> +               $1 == patch     { exit }
> +                               { print }
> +               ' patch="${patch//\\/\\\\}" $DB

What about passing parameters to awk on the command line; will that work ?

--
John

mail-sun-awk.diff
Description: Binary data