Re: [Simulavr-devel] 13-pre3 patch

[ken restivo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

that was it. a million thanks. i'm embarassed that i didn't catch that.

- -ken
- --------
On Mon, Jan 07, 2002 at 01:21:04PM -0700, Theodore A. Roth wrote:
> This is a bug in the LSR opcode handler. Here's the potential fix:
> 
> cat > LSR_cary_fix.patch <<EOF
> Index: decoder.c
> ===================================================================
> RCS file: /cvsroot/simulavr/simulavr/src/decoder.c,v
> retrieving revision 1.11
> diff -u -r1.11 decoder.c
> --- decoder.c   29 Dec 2001 06:49:11 -0000      1.11
> +++ decoder.c   7 Jan 2002 20:15:28 -0000
> @@ -1790,7 +1790,7 @@
>  
>      byte sreg = avr_core_sreg_get( core );
>  
> -    sreg = set_bit_in_byte( sreg, SREG_C, C = (rd & 0xf) );
> +    sreg = set_bit_in_byte( sreg, SREG_C, C = (rd & 0x1) );
>      sreg = set_bit_in_byte( sreg, SREG_N, N = (0) );
>      sreg = set_bit_in_byte( sreg, SREG_V, V = (N ^ C) );
>      sreg = set_bit_in_byte( sreg, SREG_S, S = (N ^ V) );
> EOF
> 
> With this I got 0, 0, 4, 0 output as expected. Once you verify that this 
> is indeed the fix, I'll commit it to cvs.
> 
> Ted
> 
> On Sun, 6 Jan 2002, ken restivo wrote:
> 
> :)i was able to build 13-pre3, and gdb, no prob. the build system worked
> :)cleanly and quietly. very cool.
> :)
> :)but i found a strange problem.
> :)
> :)this test program successively writes the bytes "0, 0, 7, 0" to PORTC,
> :)whereas i was expecting it to write the bytes "0, 0, 4, 0".
> :)
> 
> 
> _______________________________________________
> Simulavr-devel mailing list
> address@hidden
> http://mail.freesoftware.fsf.org/mailman/listinfo/simulavr-devel

- -- 
- ------------------
One world. Many gods. Plenty for everyone.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8OjWse8HF+6xeOIcRAlTtAKCeJ+VUorIC9ODt6ebjl33rg+r8pwCgp2sy
Oi0+Y0GgGiFyFxeBcH6JvRs=
=J46Q
-----END PGP SIGNATURE-----