Re: [Tcd-hackers] tcd 2.1.2-cvs-20031006 not 'working' at all

[Robert Millan]

On Mon, Oct 06, 2003 at 03:17:39PM +0200, Jan Engelhardt wrote:
> Hi,

Hello!

> I just downloaded the CVS tree, and after compiling, tcd says "No Audio". I
> first thought it was due to SDL which probably did not knew devfs.
> It did not (SDL only checks for /dev/cdrom, /dev/hd? /dev/scd? and /dev/sr?),
> however I could either set the SDL_CDROM environment variable or link
> /dev/cdrom to /dev/discs/cdrom0. So it was not SDL.
> 
> Puzzled about it, I traced through TCD and saw that the track list etc. is not
> updated. It originally was in tcd_readtoc() in linux-cdrom.c, but that is not
> called. This should be fixed before I can bend my patch(es) to patch against
> CVS ;)

My SDL changes are not complete and need some cleanup. IIRC the user interface
is not updated but input commands work. Try hitting the play key, even if TCD
doesn't show any disc.

If this is really an impediment for merging your patches, you'll have to wait
untill someone has time to look at it (not me atm). But I think you can test
your patch in the current state.

Of course, if you want to fix it you're welcome to.

> >Also mind differing it against CVS, there's no point in appliing your patch
> >in the 2.1.0 released version.
> However I am sure "patch" will get it right. But when I see the major
> difference against 2.1.2, then again, maybe not.

Not for all parts, since you modified code that has been changed to some
extent.

Again, please split your patch in a set of patches for each fix/improvement
with associated brief (1-2 lines) description (preferably in ChangeLog
format). Then I can apply some of them even if you don't update it to CVS.

And again, thanks for your interest.

-- 
Robert Millan

"[..] but the delight and pride of Aule is in the deed of making, and in the
thing made, and neither in possession nor in his own mastery; wherefore he
gives and hoards not, and is free from care, passing ever on to some new work."

 -- J.R.R.T, Ainulindale (Silmarillion)