Re: [Tcd-hackers] tcd 2.1.2-hx patches

[Jan Engelhardt]

>Generaly (in free sw projects) attachments are preferred. The reason is that
>using URLs the patches are not stored in the ML archives and may be lost in
>time. It's ok for this time though, I tested your patches a bit:
>
>hx1: ok, commited.
>hx2: fixed the borders but messed up the rest of the blue lines, have a look.

hm, yes. I accidentally seem to have removed a line too much when porting the
patch from 2.1.0 to 2.1.2. In -hx2.diff you will find:

@@ -327,23 +327,42 @@
    print_help();

    attron( C_BLUE );
-   box(win, ACS_VLINE, ACS_HLINE);
-   wmove(win,...)

and so on. Add the box() command back into the source.

>hx3: couldn't test it (because of the other bug with the GUI), but if it works
>     with pre-SDL i'd commit it anyway.

That was the tracklist patch. It doesnot share any chunks so it can be applied
any time later.

>hx4: won't compile, please have a look.

Oh yes, right. That is because in update_tracklist(), it says "cd->" all over
the place, but since >2.1.0 cd is not a pointer anymore, but just a struct. So
you need to replace "cd->MEMBER" to "cd.MEMBER".

And with the current cflags, gcc warns about the use of //, which is
"a C++ style comment not allowed in C90". Though this is allowed in
the _standard_ invocation of gcc. Change to /* */.

-- 
- Jan Engelhardt