Re: [Wesnoth-dev] New multiplayer chat preferences

[Andreas Grosse]

Hi there,

on Ott's request I reviewed my patches again and submitted them to
tracker as ID 4047:
https://savannah.nongnu.org/patch/index.php?func=detailitem&item_id=4047

It is still the same functionality and applies to the latest CVS
version. I checked the changes made by DarthFool and decided not to put
my preferences in the "Advanced" section, but to stick with the
Multiplayer tab, for the following reasons:

I don't think that the "Advanced" tab is needed, and it might have
negative effects. Enabling non-binary saves is in my opinion a feature
which is not neeeded by normal users and it encourages cheating since
modifying the save game is easier. I think having this configurable is a
good thing, but via console would suffice. Besides, the advanced tab is
the perfect place for developers to put all their stuff which didn't fit
elsewhere, which is a bad habit. And, as the last point, it looks
different than all other tabs, and it's user interface is not very
intuitive. But that might be a different discussion. </rant> :-)

I also checked if I could somehow use the timestamp code DarthFool uses
for his theme, but that doesn't work. I'd suggest that someone with more
experience than me checks for all usages of time() and strftime() calls
and builds a generic utils::time object (or something like that), to
counter re-coding the same stuff over and over. 
What I took from DarthFools code is the preferences::clock_format() for 
the chat timestamp, so that is configurable now as well.

Anyway, I already got lots of positive feedback for my patch, so I hope 
that it does finally make it into mainstream wesnoth; I am really 
reluctant to review the patches once a month to make them again apply.

    majestyk


Andreas Grosse <address@hidden> [28:04:05 18:16] wrote:
> Hi,
> 
> after some talking via IRC I decided to show the actual number of lines
> configured with the slider next to the slider. To make things easier for
> you to check, I created a new patch (which still applies fine to the
> latest CVS version) AND I made a screenshot how it looks like. It is
> available at http://www.rot13.de/~majestyk/wesnoth-mp-prefs.png .
> 
> Now I need a developer willing to review the code, so that the changes
> get merged into the CVS. Is there a volunteer? :-)
> 
> Cheers,
>         majestyk
> 
> Andreas Grosse <address@hidden> [22:04:05 11:16] wrote:
> > Hi,
> > 
> > I recently joined the wesnoth community, and I have a few ideas about 
> > what could be improved in some parts. Instead of buggering you with
> > implementing my features, I tried to do so myself. Since I am not a
> > seasoned C++ programmer, I'd really appreciate if someone could review
> > my attached patches. If there is a consensus about the integration, I'd
> > be happy if these changes could be merged for the next version.
> > 
> > The things I wanted to improve are focused on multiplayer chat. On my
> > first online match, things went really slow, so I wasn't always at my
> > machine. Returning to it, I would have been happy to have the messages
> > timestamped, to be able to trackback when something happened. Second,
> > when playing on a small resolution 6 lines of chat messages are just too
> > much, and I thought making it configurable would be nice.
> > 
> > Summary of changes:
> > - created a new preferences tab, called "Multiplayer"
> > - created a button called "Chat Timestamping", prepending the chat lines
> >   with a "H:m:s" timestamp (e.g.:   21:42:23 <majestyk> test line )
> > - created a slider called "Chat Lines", changing the amount of displayed
> >   lines from 1 to 20 lines.
> > 
> > To work 100%, a new image is needed for the multiplayer tab. For test
> > purposes, I used the silver mage because I like the image :-)
> > # cp images/silver-mage.png images/icons/multiplayer.png
> > 
> > I'd be grateful for almost every kind of feedback :)
> > 
> > Cheers,
> >     majestyk

multiplayer-prefs-260505.diff
Description: Text document