bug-bash
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Makefile: avoid undefined variables


From: Chet Ramey
Subject: Re: [PATCH] Makefile: avoid undefined variables
Date: Sat, 26 Oct 2024 12:53:41 -0400
User-agent: Mozilla Thunderbird

On 10/24/24 3:07 PM, Grisha Levit wrote:
These are reported by make --warn-undefined-variables.

Most were being set previously (sometimes 20 years ago) and got left
behind in recepies after their definitions have been removed. Others
only get set in some configurations so it makes sense to prevent them
from inheriting stray values from the environment otherwise. A few are
just typos.

Thanks for the cleanups.

This leaves only a couple warnings:
* BASH_MAKEFLAGS: not sure if still necessary after the MFLAGS removal?

I left it in in case some build configs want to use it in the same way
as they used MFLAGS; we should initialize it to empty.

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]