[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Makefile: avoid undefined variables
|
From: |
Martin D Kealey |
|
Subject: |
Re: [PATCH] Makefile: avoid undefined variables |
|
Date: |
Sun, 27 Oct 2024 00:32:23 +1000 |
On Sat, 26 Oct 2024, 00:05 Dmitry Goncharov, <dgoncharov@users.sf.net>
wrote:
> > - cd $(@D) && $(MAKE) BUILD_DIR=$(UP)$(BUILD_DIR)
> > top_srcdir=$(UPSRC)$(top_srcdir) $(MAKEFLAGS) $(@F)
>
> It is really not a good idea to pass makeflags on the command line as a
> positional parameter.
Agreed, but I was just copying what's already there. So let's add that to
the list of things to fix.
-Martin