Re: [PATCH] Makefile: avoid undefined variables

[Chet Ramey]

On 10/26/24 10:32 AM, Martin D Kealey wrote:
> On Sat, 26 Oct 2024, 00:05 Dmitry Goncharov, <dgoncharov@users.sf.net>
> wrote:
>
> > >     - cd $(@D) && $(MAKE) BUILD_DIR=$(UP)$(BUILD_DIR)
> > >     top_srcdir=$(UPSRC)$(top_srcdir) $(MAKEFLAGS) $(@F)
> >
> > It is really not a good idea to pass makeflags on the command line as a
> > positional parameter.
>
>
> Agreed, but I was just copying what's already there. So let's add that to
> the list of things to fix.

It's just not a good idea to do that anyway; let configure fill in
BUILD_DIR.

--
``The lyf so short, the craft so long to lerne.'' - Chaucer
                 ``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU    chet@case.edu    http://tiswww.cwru.edu/~chet/

OpenPGP_signature.asc
Description: OpenPGP digital signature