[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Makefile: avoid undefined variables
|
From: |
Dmitry Goncharov |
|
Subject: |
Re: [PATCH] Makefile: avoid undefined variables |
|
Date: |
Fri, 25 Oct 2024 10:05:27 -0400 |
> - cd $(@D) && $(MAKE) BUILD_DIR=$(UP)$(BUILD_DIR)
> top_srcdir=$(UPSRC)$(top_srcdir) $(MAKEFLAGS) $(@F)
It is really not a good idea to pass makeflags on the command line as
a positional parameter.
A variable (any variable, including makeflags) set on the command
line, overrides the value in make's memory.
In the case of makeflags, make itself sets makeflags according to the
command line switches specified by the user.
And then, a command line definition of makeflags wipes out those
switches from make's memory and the switches do not get to submake.
Unless you are using some ancient version of make, there is no need to
pass makeflags on the command line.
See https://savannah.gnu.org/bugs/?62469
regards, Dmitry