[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on
From: |
Christopher M. Miles |
Subject: |
Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist` |
Date: |
Mon, 15 May 2023 20:43:55 +0800 |
User-agent: |
mu4e 1.10.3; emacs 30.0.50 |
Ihor Radchenko <yantar92@posteo.net> writes:
> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>>> You are almost there.
>>> Just run your code only when (lentgh> fulltable 26).
>>>
>>> Of course, 26 should be a defcustom rather than a hard-coded constant.
>>> And do the same for `org-fast-todo-selection'.
>>
>> Ok, I added defcustom option, and add cl-case condition on custom option
>> `org-use-fast-tag-selection'.
>
> I do not think that we need to care about the value of
> `org-use-fast-tag-selection'. Instead, just
>
> 1. If the total number of tags does not exceed
> `org-fast-tag-selection-maximum-tags', display them all.
> 2. If the total number of tags is larger, just display all the bound
> tags + any extra tags, up to `org-fast-tag-selection-maximum-tags',
> and add a note in the tag selection buffer that more tags are not
> displayed.
I think we should consider the option `org-use-fast-tag-selection'.
Because it controls the behavior that whether auto assign short-key to
tags. Make condition decision based on this option is needed. I hope you
can reconsider this.
--
[ stardiviner ]
I try to make every word tell the meaning that I want to express without
misunderstanding.
Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
signature.asc
Description: PGP signature
- [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, (continued)
- [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/13
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/13
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/13
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/14
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/14
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/14
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/14
- Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/14
- [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/14
- Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/15
- Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`,
Christopher M. Miles <=
- Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/15
- [PATCH v3] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/15
- [PATCH v3.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/15
- Re: [PATCH v3.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/16
- [PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/16
- Re: [PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Ihor Radchenko, 2023/05/16
- [PATCH v4.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/17
- [PATCH v4] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/16
Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`, Christopher M. Miles, 2023/05/13