Re: [PATCH v2] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

[Ihor Radchenko]

"Christopher M. Miles" <numbchild@gmail.com> writes:

>> I do not think that we need to care about the value of
>> `org-use-fast-tag-selection'.  Instead, just
>>
>> 1. If the total number of tags does not exceed
>>    `org-fast-tag-selection-maximum-tags', display them all.
>> 2. If the total number of tags is larger, just display all the bound
>>    tags + any extra tags, up to `org-fast-tag-selection-maximum-tags',
>>    and add a note in the tag selection buffer that more tags are not
>>    displayed.
>
> I think we should consider the option `org-use-fast-tag-selection'.
> Because it controls the behavior that whether auto assign short-key to
> tags. Make condition decision based on this option is needed. I hope you
> can reconsider this.

We probably have a misunderstanding about the role of
`org-use-fast-tag-selection'.

`org-use-fast-tag-selection' _currently_ determines whether to display
the tag selection window at all:

    Non-nil means use fast tag selection scheme.
    
    This is a special interface to select and deselect tags with single keys.
    When nil, fast selection is never used.
    When the symbol auto, fast selection is used if and only if selection
    characters for tags have been configured, either through the variable
    org-tag-alist or through a #+TAGS line in the buffer.
    When t, fast selection is always used and selection keys are assigned
    automatically if necessary.

Even when the value is t, not 'auto, the user bindings for tags are
honored. `org-fast-tag-selection' never checks the value of
`org-use-fast-tag-selection'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>