Re: [PATCH v3.1] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

[Ihor Radchenko]

"Christopher M. Miles" <numbchild@gmail.com> writes:

> Updated version which fix the `message` error in upper code:

Thanks!

> #+begin_src emacs-lisp
> (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable)))
>                     (if (length< fulltable 
> org-fast-tag-selection-maximum-tags)

Because of (:startgroup) markers and similar things, this condition is
not fully accurate. See `org-tag-alist' docstring.

You may also need to consider special alist items in the rest of the code.

>                         fulltable
>                       (if (length< bound-tags 
> org-fast-tag-selection-maximum-tags)
>                           (progn
>                             (insert "Tags are limited displayed by 
> `org-fast-tag-selection-maximum-tags'.\n")

If you want to have proper Elisp symbol markup when using `...', use 
`format-message'.

>                             (seq-take (seq-uniq (append bound-tags fulltable))
>                                       org-fast-tag-selection-maximum-tags))

This will behave awkwardly with tag groups. You may better use 
`org--tag-add-to-alist'.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>