Re: [Gnash-dev] [COMMITTED] inclusion of ffmpeg patch into Gnash 0.8.2 ?

[Bastiaan Jacques]

On Fri, 22 Feb 2008, strk wrote:
> Next thing to look at (in head) would be proper abstractions to
> reduce (ideally drop) ifdefs around and duplication of common code.

I've done most of this in HEAD for embedded video. Arguably some more
work could be done in the sound handler area. I'll consider applying
the embedded video patch to the branch if it receives positive feedback
(but not before).

> In particular, I belive using NetConnection for handlign the actual
> data download is the way to go

For ffmpeg this is the only way to do it, as far as I know. As for
Gstreamer it gets problematic because marshalling the data to and from
the NetConnection (thread) to the decoding thread is not straight
forward. That said, it is almost inevitable since we will soon be
retrieving data from RTMP sources, which will presumably be abstracted
into NetConnection.

> For the aux_streamer I still don't know as the whole sound_handler
> class is not properly documented as of yet - see top comments in
> libmedia/sound_handler.h, the \page section must be written
> completely. Documenting works would be appreciated.

Hong Yu ('s team) has documented the aux_streamer call. However, the
rest of the sound handler's documentation is severely lacking. But
before we worry about documentation we need to decide whether or not the
current interface is a good one. I think there is a lot of room for
cleanup in order to make it more maintainable.

Bastiaan