[Gnash-dev] Re: [Gnash-commit] gnash ChangeLog configure.ac doc/C/usermanual/g... [release_0_8_2_rc1]

[Sandro Santilli]

On Thu, Feb 28, 2008 at 04:58:34PM +0100, Bastiaan Jacques wrote:
> On Thu, 28 Feb 2008, Sandro Santilli wrote:
> 
> >             * configure.ac: never attempt to use libmad, fallback to 
> >             ffmpeg if
> >               gstreamer is not supported and not explicitly requested.
> 
> I don't agree with this change. I don't think we want users to fall back
> on ffmpeg when they don't have gstreamer, only to discover various
> instabilities when they play various media containing movies. Users
> won't see the warning "trying ffmpeg now" and will blindly assume that
> they have the right dependencies.

I tought you fixed the instabilities recently.

Anyway, the fallback code is only in effect if no --enable-media switch
was given.  If you give --enable-media=gst configure will abort with an
error when deps are not met.

This is to allow quick configurations, where the user just wants to build
what's possible.

We do a similar thing with the GUIs, not having gtk or kde doesn't trigger
an error at ./configure time (not sure if the "abort if explicit requested"
policy was ever finished for the GUI though).

> In my opinion, we should make configure abort if gstreamer isn't found,
> and tell the user that "it's not well supported currently, but if you
> want to you can try --enable-media=ffmpeg".

The following patch pretends an --enable-media=gst was given, which should
give what you request with minimal change in the configure.ac file.

Would like to hear other's opinion before committing it.

--strk;

Index: configure.ac
===================================================================
RCS file: /sources/gnash/gnash/configure.ac,v
retrieving revision 1.479.2.5
diff -u -r1.479.2.5 configure.ac
--- configure.ac        28 Feb 2008 08:16:16 -0000      1.479.2.5
+++ configure.ac        28 Feb 2008 16:15:30 -0000
@@ -596,7 +596,7 @@
      ;;
    *) AC_MSG_ERROR([bad value ${enableval} for --enable-media option]) ;;
   esac],
- [media_handler=gst]
+ [media_handler=gst; media_handler_specified=true]
 )

 AC_ARG_ENABLE(lirc, AC_HELP_STRING([--enable-lirc], [Disable support for 
Lirc]),