Re: lynx-dev [PATCH 2.8.3.dev4] Make prettysrc available from lynx.cfg

[Vlad Harchev]

On Fri, 6 Aug 1999, Klaus Weide wrote:

> On Thu, 5 Aug 1999, Vlad Harchev wrote:
> > On Thu, 5 Aug 1999, Ilya Zakharevich wrote:
> > 
> > > >> This makes prettysrc available from lynx.cfg
> > > >> .
> > > >> Btw, what is the logic?  Why some options cannot be set from lynx.cfg?
> > > >
> > > >Turning prettysrc on is more than "enabling" it.  It overrides
> > > >the way '\' acts on text/html files, therefore it makes the normal
> > > >SOURCE display unavailable.  If you 'P'rint from this 'source' view
> > > >(e.g. to disk, to mail), you don't get in general valid text/html
> > > >source.
> > 
> > Klaus, did you mean wrapping of tag names and attribute names here?
> 
> I meant
> (1) wrapping of any source text lines that are longer than the display
>     width minus 1.  I am not aware of any wrapping concerns that are
>     specific to tag names and attribute names, for -prettysrc.

 I'll try to fix it when I'll have some time. Only now I've understood that
it's broken in this respect (I afraid mailing with lynx). 

> (2) Insertion of "[nn]" if "Links are numbered" is enabled, which makes
>     all hrefs invalid.

  (2) Can't be fixed obviously.
 
>[...] 
> I always thought of -preparsed as something that no one would (or should)
> enable on a permanent basis to replace regular SOURCE mode.  After all
> it doesn't just give a different rendering of the same old source, it
> tries to show the source after lynx has premasticated it.  The same may 
> not be exactly true for the -prettysrc variety of source display.

 May be (but it would be useful if it was bound to special key so user will be
able to see -preparsed view and either normal or pretty without restarting
lynx). Providing the ability to chose one of 3 views in the 'O'ptions menu can 
compensate the things.
 
> Note that there is a different confirmation prompt for the 'P'rint menu,
> at least for "Mail the file", if the 'P' is invoked from -preparsed
> SOURCE.  The idea is that a user sending the putative source to himself
> (or somewhere else) should be reminded that no, this isn't the original
> source.

 I didn't find this (can you provide a sequence of keypresses and emphasis the
difference in the texts) - may be I misunderstood.

> An additional complication is that -preparsed also modifies the handling
> of non-interactive -source.

 Is this intentional? If no, is this bad?

> > To Klaus: If you think there are bugs in the implementation of psrc mode,
> > please tell about them explicitly (rather than saying that it's almost
> > broken).
> 
> Well, the (1) and (2) above were so obvious to me that I thought that you
> must be aware of them, and that you obviously did not intend pretty source
> view as a full replacement for regular source view.

 No, I wasn't aware of them.
 
> >[...] 
> > And to Klaus: 
> >  As I understand you, you mean that it will be impossible to request 'old'
> > source view if PRETTYSRC:TRUE is inserted in lynx.cfg (and seems this is 
> > your
> > most valuable objection)? If yes, then type of -prettysrc should be changed 
> > to
> > the one that allows such change (may be PARSE_SET)?
> 
> Actually, it seems I was wrong about one thing: using -prettysrc=off, it
> should still be possible with Ilya's patch to turn it off from the command
> line.  So no change of -prettysrc is necessary to make this possible.
> (It could be turned into a toggle, but that would be more incompatible to
> its previous meaning.)

 Yes, you were wrong about inability of retunring back to 'old' source view
after applying  Ilya's patch.
 
> So the major objection is missing documentation.  Apart from that,
> I question whether it makes sense to make all those command line flags
> into things that can be set also in lynx.cfg and the 'O'ptions screen.
> Maybe it does for most, but not all.  I thing you would not want to make
> -trace into a lyn.cfg-settable thing.  I think -preparsed is somewhat
> similar.  And -prettysrc may or may not be similar.

 I gave the exact list of options that seems to me should have 'O'ptions
equivialents (corresponding .lynxrc settings are under question).

> > > It is not as if we are running of bits for additional keyactions.  ;-)
> > 
> >  '|' is free for this (shift-\ - sounds very attractive) or Meta-\.
> 
> What, you want to take '|' away from LYK_PIPE? :)

 I'm so pessimistic about implementation of that functionality (I mean I
afraid I won't have time to do it in the nead future - may be somebody else?)

> I don't know whether it's a good idea to have to keys for two kinds
> of source view.
> 
> Meta-stuff isn't currently mappable for LYK_stuff in general.  I think.

 I didn't check it either.


>[...] 
> Not just packagers, but also installers and system admins.  Multiuser
> shell environments still exists, it's not like everyone runs lynx
> on their own personal machine today.
> 
> With the patch as given, and admin installing a new version for his
> users is easily tempted to turn it on - it says "Lynx will do highlighting
> and hyperlink handling in source view", sounds like a good thing to
> provide for his users.  There is no mention of any drawbacks or how to
> override it.

 Seems it's easy to add missing docs and document all possible drawbacks.

>    Klaus
> 

 Best regards,
  -Vlad