[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lzip-bug] [PATCH] lzip on Windows
From: |
Antonio Diaz Diaz |
Subject: |
Re: [Lzip-bug] [PATCH] lzip on Windows |
Date: |
Mon, 12 Oct 2009 21:33:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.7.11) Gecko/20050905 |
Dear Jon,
Thank you for the patch, but I'm afraid I can't accept it by a number of
reasons.
It is too intrusive. I am pretty sure lines like this
snprintf( buf, sizeof buf, "%"LZIPLL"d %s", num, p );
will break compilation on some other systems.
It is for a system too different from posix systems, and there is at
least a way of compiling lzip in windows that does not need to obscure
the code with conditional compilation constructs; Cygwin.
It is for a concrete compiler, MSVC. But you say that "it doesn't work
with MSVC yet"!
Have you considered the possibility of maintaining a port? Ports for
systems very different from the original help to maintain the upstream
source clean and simple.
Regards,
Antonio.
- [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/11
- Re: [Lzip-bug] [PATCH] lzip on Windows, Antonio Diaz Diaz, 2009/10/11
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/11
- Re: [Lzip-bug] [PATCH] lzip on Windows, Jon, 2009/10/12
- Re: [Lzip-bug] [PATCH] lzip on Windows,
Antonio Diaz Diaz <=
- Re: [Lzip-bug] [PATCH] lzip on Windows, Tino Lange, 2009/10/12
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/12
- Re: [Lzip-bug] [PATCH] lzip on Windows, Antonio Diaz Diaz, 2009/10/13
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/13
- Re: [Lzip-bug] [PATCH] lzip on Windows, Antonio Diaz Diaz, 2009/10/13
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/14
- Re: [Lzip-bug] [PATCH] lzip on Windows, Tino Lange, 2009/10/14
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/14
- Re: [Lzip-bug] [PATCH] lzip on Windows, Antonio Diaz Diaz, 2009/10/14
- Re: [Lzip-bug] [PATCH] lzip on Windows, JonY, 2009/10/14