Re: [Lzip-bug] [PATCH] lzip on Windows

[Tino Lange]

> It is too intrusive. I am pretty sure lines like this
>   snprintf( buf, sizeof buf, "%"LZIPLL"d %s", num, p );
> will break compilation on some other systems.

> Have you considered the possibility of maintaining a port? Ports for
> systems very different from the original help to maintain the upstream
> source clean and simple.

Hi!

For me that patch worked fine on MSYS/Windows. The resulting executables
seem to do what they should do. I like it to have a "native" lzip
instead of an Cygwin included one.

An alternative to maintaining a port just for that reason would IMHO be
to simply accept larger #ifdef blocks that aren't intrusive (and hinder
easy readability) to the mainline targets. If "snprintf( buf, sizeof
buf, "%"LZIPLL"d %s", num, p );" is to intrusive then just have the
original line untouched and #ifdef a an additional/alternate WIN32 line
on windows.

Of course win32 compilation needs to be tested on all future code
changes once it is officially included in the main lzip distribution.

Cheers,

Tino