Re: [Lzip-bug] [PATCH] lzip on Windows

[JonY]

On 10/13/2009 03:33, Antonio Diaz Diaz wrote:
> Dear Jon,
>
> Thank you for the patch, but I'm afraid I can't accept it by a number of
> reasons.
>
> It is too intrusive. I am pretty sure lines like this
> snprintf( buf, sizeof buf, "%"LZIPLL"d %s", num, p );
> will break compilation on some other systems.
>
> It is for a system too different from posix systems, and there is at
> least a way of compiling lzip in windows that does not need to obscure
> the code with conditional compilation constructs; Cygwin.

Hi,

I just found a massive thinko with my previous patches, not sure why it 
worked at all. In the mean time, I'll still try to find a less intrusive 
method.

I have to agree, your code does look clean from a POSIX perspective, 
thanks for your input.