[Octave-bug-tracker] [bug #63437] Null pointer dereference in file-editor-tab.cc

[John W. Eaton]

Follow-up Comment #8, bug #63437 (project octave):

I don't think we should have hard-coded defaults that are scattered across
many files.  That would make changing defaults difficult and likely to lead to
inconsistencies.

Instead, we should ensure that the settings object is initialized and used
correctly.  If it is not valid for some reason, that should be a fatal error,
preferably displayed in a way that will help us diagnose what the problem is.

Is it possible that the settings object is not defined when it is accessed?

Are operations on the settings object thread safe?  If not, then I'm not sure
that we can expect things like


  gui_settings *settings = rmgr.get_settings ();
  if (settings)
    notice_settings (settings, true);


to work reliably because another thread may also be using the settings object.
 Instead, we'll need to use a signal/slot connection to perform this
operation.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63437>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/