[Octave-bug-tracker] [bug #63437] Null pointer dereference in file-editor-tab.cc

[John W. Eaton]

Follow-up Comment #10, bug #63437 (project octave):

If we can ensure that the settings object is always valid, then I agree that
we shouldn't need to have "if (settings)".

A separate issue is that the QSettings class that our gui_settings class is
derived from is not thread safe, so simply calling notice_settings is not safe
because we don't know what other threads might be using the gui_settings
object at the same time.  Maybe I'm missing something, but I think all uses of
the settings object should use signal/slot connections, not direct calls.


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?63437>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/