[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fiel
From: |
Fabiano Rosas |
Subject: |
[Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields |
Date: |
Mon, 12 Mar 2018 19:07:51 -0300 |
The throttle driver is not a protocol so it should implement bdrv_open
instead of bdrv_file_open and not provide a protocol_name.
Attempts to invoke this driver using protocol syntax
(i.e. throttle:<filename:options:...>) will now fail gracefully:
$ qemu-img info throttle:foo
qemu-img: Could not open 'throttle:foo': Unknown protocol 'throttle'
Signed-off-by: Fabiano Rosas <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
---
block/throttle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/throttle.c b/block/throttle.c
index 5f4d43d0fc..95ed06acd8 100644
--- a/block/throttle.c
+++ b/block/throttle.c
@@ -215,10 +215,9 @@ static void coroutine_fn
throttle_co_drain_end(BlockDriverState *bs)
static BlockDriver bdrv_throttle = {
.format_name = "throttle",
- .protocol_name = "throttle",
.instance_size = sizeof(ThrottleGroupMember),
- .bdrv_file_open = throttle_open,
+ .bdrv_open = throttle_open,
.bdrv_close = throttle_close,
.bdrv_co_flush = throttle_co_flush,
--
2.13.6
- [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 1/5] block/replication: Remove protocol_name field, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields,
Fabiano Rosas <=
- [Qemu-block] [PATCH v2 2/5] block/quorum: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 4/5] block/blkreplay: Remove protocol-related fields, Fabiano Rosas, 2018/03/12
- [Qemu-block] [PATCH v2 5/5] include/block/block_int: Document protocol related functions, Fabiano Rosas, 2018/03/12
- Re: [Qemu-block] [PATCH v2 0/5] block: Ensure non-protocol drivers can only be selected explicitly, Kevin Wolf, 2018/03/20