|
From: | Alberto Garcia |
Subject: | Re: [Qemu-block] [PATCH v2 3/5] block/throttle: Remove protocol-related fields |
Date: | Wed, 14 Mar 2018 16:18:06 +0100 |
User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Mon 12 Mar 2018 11:07:51 PM CET, Fabiano Rosas wrote: > The throttle driver is not a protocol so it should implement bdrv_open > instead of bdrv_file_open and not provide a protocol_name. > > Attempts to invoke this driver using protocol syntax > (i.e. throttle:<filename:options:...>) will now fail gracefully: > > $ qemu-img info throttle:foo > qemu-img: Could not open 'throttle:foo': Unknown protocol 'throttle' > > Signed-off-by: Fabiano Rosas <address@hidden> > Reviewed-by: Max Reitz <address@hidden> Reviewed-by: Alberto Garcia <address@hidden> Berto
[Prev in Thread] | Current Thread | [Next in Thread] |